Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set tabIndex to 0 when day is focused #1601

Merged
merged 2 commits into from Nov 6, 2022
Merged

fix: set tabIndex to 0 when day is focused #1601

merged 2 commits into from Nov 6, 2022

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented Nov 6, 2022

Fixes #1586.

Analysis

Day buttons with focus should have tabIndex=0, otherwise browsers tab key will focus the previous month button when tabIndex=-1.

Solution

Set tabIndex to 0 when the day is focused.

@gpbl gpbl changed the title fix: set tabIndex to 0 when day isFocused fix: set tabIndex to 0 when day is focused Nov 6, 2022
@gpbl gpbl merged commit 3ee1922 into master Nov 6, 2022
@gpbl gpbl deleted the gpbl/issue1586 branch November 6, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: tabIndex toggling from 0 to -1 on today or selected day for the first time
1 participant