-
Notifications
You must be signed in to change notification settings - Fork 111
[WIP] Linting with eslint and husky #710
base: develop
Are you sure you want to change the base?
Conversation
@adamzerella, What you think about #700 (comment) ? Summary easy way to make js code IE8 compliant: stick with es5 syntax and recommend users to apply polyfills if they actually need an IE8 support es-shim, DOM-shim. Or start to use transpile or even some of bundler (rollup etc.) on jQuery includes some polyfills as i know, so actualy don't need to do anything here (just es5 and jQuery API). |
We don't have a choice when it comes to IE8 support, it's something that we support @toxamiz. We might need to create a IE8 complaint |
@adamzerella but you already using and relying on polyfills. In every test file you have html5-shiv and media-query polyfill for breakpoints from Can you explain, please, why you are refusing to use ie8 polyfills here? es5 requirement and polyfills for ie8 will solve this problem. |
@toxamiz We are relying on polyfills where it makes sense. We are currently using Linting and shivs are unrelated to one another. We need a way to lint our vanilla JavaScript so that it's extremely compatibility across browsers, this means linting for things like using You're right in saying we could just polyfill when we transpile the vanilla JavaScript but this isn't always going to work ( babel isn't perfect ) and it would increase our bundle sizes. |
2099772
to
2beb197
Compare
As drafted by @toxamiz in #700, this is a more workable branch.
Issue reference: #429
Todo: