Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Control and radio input groups #548

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sukhrajghuman
Copy link
Contributor

@sukhrajghuman sukhrajghuman commented Nov 8, 2018

fixes #544

Will need to update docs on design system site also to reflect this.

Basically made RadioList and CheckboxList components which control the state of the checked items and has callbacks into the parent component

@sukhrajghuman sukhrajghuman self-assigned this Nov 8, 2018
@sukhrajghuman sukhrajghuman added the 🐛 bug Something isn’t working the way it should. label Nov 8, 2018
@sukhrajghuman sukhrajghuman added this to the Sprint 116 milestone Nov 8, 2018
@sukhrajghuman sukhrajghuman added this to 🔬 QA in Design System Nov 9, 2018
Design System automation moved this from 🔬 QA to ✨ Done Nov 13, 2018
@alex-page
Copy link
Contributor

alex-page commented Nov 20, 2018

Hmmm i'm not too sure on this one, the components were pretty clean before and maybe we are now supporting too much?

I assume most people would write code to handle this state themselves ( especially in forms )?

Also this branch has unmerged commits 😕

@sukhrajghuman sukhrajghuman reopened this Nov 23, 2018
@sukhrajghuman
Copy link
Contributor Author

Will discuss the option of having radio and checkbox list react components

@sukhrajghuman sukhrajghuman added submitted by user Issues on behalf of users. and removed 🐛 bug Something isn’t working the way it should. labels Nov 23, 2018
@alex-page alex-page changed the title Fix control input react [WIP] Control and radio input groups Nov 29, 2018
@azerella azerella force-pushed the develop branch 5 times, most recently from c343bcc to 1b6a5f2 Compare March 1, 2019 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
submitted by user Issues on behalf of users.
Projects
Design System
  
✨ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants