Move migrate-from-testify to separate module #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test TestRun of the gty-migrate-from-testify tool apparently needs
to have the original packages available to run. So let's install them
("go get" in GOPATH mode, in a temporary directory) before running the
migration test.
…-check Fix incorrect import path for go-check in gty-migrate-from-testify test: github.com/go-check/check => gopkg.in/check.v1
…test Fix test to use the gopkg.in/check.v1 API correctly. The func TestWithChecker(c *check.C) was incompatible with "go test".
dolmen
suggested changes
Jul 3, 2023
| goGet(t, "gopkg.in/check.v1") | ||
| goGet(t, "github.com/stretchr/testify/assert") | ||
| goGet(t, "github.com/stretchr/testify/require") | ||
|
|
There was a problem hiding this comment.
I don't like the idea of having to exec the go get command from inside a test. There's nothing special about this test that should require running extra commands which are going to be relatively slow and will fail when there is no network.
I'd like to understand why only the Go1.19 job is failing in CI, that's really surprising to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
Closes #265 (those commits are included in this PR)