Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert.Empty #251

Closed
wants to merge 4 commits into from
Closed

Add assert.Empty #251

wants to merge 4 commits into from

Conversation

skelouse
Copy link

Fixes #250

@skelouse skelouse changed the title Add assert.Empty and test Add assert.Empty Jan 25, 2023
@CLAassistant
Copy link

CLAassistant commented Jan 25, 2023

CLA assistant check
All committers have signed the CLA.

@dolmen
Copy link
Contributor

dolmen commented Jun 12, 2023

👍 for cmp.Zero because the zero value of a type is well-defined in Go.
👎 for cmp.Empty because empty is more ambiguous (ex nil slice vs slice of len 0 vs slice of capacity 0).

@skelouse
Copy link
Author

skelouse commented Oct 7, 2023

Initial issue was not accepted, and generics will handle this better if someone wants to implement something similar in the future.

@skelouse skelouse closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add call Empty(values ...any)
3 participants