Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: improve godoc and failure messages #229

Merged
merged 6 commits into from Apr 16, 2022

Commits on Apr 16, 2022

  1. assert: remove build tag for ErrorIs

    Go 1.12 (the last version before errors.Is was added) has not been
    supported in a while.
    
    Move ErrorIs assertion and comparison into the main files.
    dnephin committed Apr 16, 2022
    Copy the full SHA
    2d58ab7 View commit details
    Browse the repository at this point in the history
  2. assert: improve godoc

    Add examples to godoc that show the failure message.
    
    Improve the failure message for assert.Assert when the argument is an
    ast.Ident, or a binary expression.
    dnephin committed Apr 16, 2022
    Copy the full SHA
    42d5739 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    6d318f1 View commit details
    Browse the repository at this point in the history
  4. assert: improve failure message for ErrorIS

    Removes the stdlib error types from the failure message
    (*errors.errorString, and fmt.wrapError). These types are not relevant because
    they come from using fmt.Errorf or errors.New. The type of the error is only
    relevant when the error is a user defined type.
    dnephin committed Apr 16, 2022
    Copy the full SHA
    0173ef4 View commit details
    Browse the repository at this point in the history
  5. env: deprecate Patch

    dnephin committed Apr 16, 2022
    Copy the full SHA
    9c6ef76 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    f270cc3 View commit details
    Browse the repository at this point in the history