Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating directory outside of testdata #223

Merged
merged 1 commit into from Jan 4, 2022

Conversation

seriousben
Copy link
Contributor

@seriousben seriousben commented Jan 3, 2022

This pull request makes it so that updating golden files within sub folders of testdata don't create them outside of testdata.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the bug fix! I believe I introduced this bug in #209, and I guess tests do not notice the problem because they always use absolute paths.

@dnephin dnephin merged commit 7fe928e into gotestyourself:main Jan 4, 2022
@seriousben seriousben deleted the fix-golden-dir-creation branch January 4, 2022 00:54
@seriousben
Copy link
Contributor Author

Thanks for merging, do you know when a new release will be created? There is a lot of good unreleased changes.

@dnephin
Copy link
Member

dnephin commented Jan 15, 2022

Sorry for the delay, this is done now: https://github.com/gotestyourself/gotest.tools/releases/tag/v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants