Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golden: only create dir if update flag is set #215

Merged
merged 1 commit into from Feb 3, 2021
Merged

golden: only create dir if update flag is set #215

merged 1 commit into from Feb 3, 2021

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Feb 3, 2021

Fixes #214

@dnephin dnephin mentioned this pull request Feb 3, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 3, 2021 •
edited

Codecov Report

Merging #215 (fbb0800) into main (de21663) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   82.65%   82.65%           
=======================================
  Files          28       28           
  Lines        1649     1649           
=======================================
  Hits         1363     1363           
  Misses        189      189           
  Partials       97       97
Impacted Files Coverage Δ
golden/golden.go 86.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de21663...fbb0800. Read the comment docs.

@ndeloof ndeloof mentioned this pull request Feb 3, 2021
Merged
@vdemeester vdemeester merged commit 1df0ee5 into gotestyourself:main Feb 3, 2021
@dnephin dnephin deleted the mkdir-in-update branch February 3, 2021 16:07
@renovate renovate bot mentioned this pull request Jan 15, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Mar 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@ndeloof ndeloof ndeloof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golden file trigger unexpected folder creation
3 participants
@dnephin @vdemeester @ndeloof