Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first unit tests to Gosu (#360) #368

Merged
merged 3 commits into from Jan 12, 2017
Merged

Add first unit tests to Gosu (#360) #368

merged 3 commits into from Jan 12, 2017

Conversation

jlnr
Copy link
Member

@jlnr jlnr commented Jan 7, 2017

No description provided.

@jlnr jlnr self-assigned this Jan 7, 2017
@jlnr jlnr force-pushed the tests branch 2 times, most recently from 9e9ac3a to ad7e40f Compare January 7, 2017 10:58
@jlnr
Copy link
Member Author

jlnr commented Jan 7, 2017

@Kjarrigan I've stolen some tests from #360 and added the interface comparison I was thinking about. Still trying to get my tests to run on the Linux CI, then I'll push fixes for the red tests and merge this - and you can rebase the other tests that you have on it (calling draw_line etc. outside of Window#draw)

@jlnr
Copy link
Member Author

jlnr commented Jan 12, 2017

AAHHH WTF MICROSOFT. I've wasted quite some time getting the tests to work on Windows, when they worked all along. It's just that any program that prints anything to stderr triggers an error in PowerShell, even when the exit code is 0. Windows, not even once.

@Kjarrigan
Copy link
Collaborator

Kjarrigan commented Jan 12, 2017

Windows, not even once.

FullAck 😄
I'm glad that you figured that out, so the path as clear for the first gosu unit test 👍 ?!

@jlnr
Copy link
Member Author

jlnr commented Jan 12, 2017

For future reference, a bit of discussion happened in this commit, which has later been rebased away: 0ec4a73#commitcomment-20396274

@jlnr jlnr merged commit 458a646 into master Jan 12, 2017
@jlnr jlnr deleted the tests branch January 12, 2017 08:14
@Kjarrigan
Copy link
Collaborator

  KB_0…KB_9 = :an_integer
  KB_A…KB_Z = :an_integer

I like that new format a lot. Its definitely much cleaner than before. I still hope to get some groups in the future 😄 as I usually really just want to know the name of the button const and not the "flavour" text.
PR yard#1056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants