Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes errchecks linter #904

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

apoorvajagtap
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

As gosec catches the Error Handling loopholes, silencing the errchecks by golangci-lint.

Related Tickets & Documents

  • Will help in eliminating duplicate verification failures

Added/updated tests?

  • Yes
  • No, and this is why: only updated the golang-ci configs
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (b2a86a1) to head (b73a1a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   71.60%   71.60%           
=======================================
  Files          11       11           
  Lines        1585     1585           
=======================================
  Hits         1135     1135           
  Misses        345      345           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexVulaj AlexVulaj merged commit e5f1a0a into gorilla:main Mar 20, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants