Do not timeout when WriteControl deadline is zero #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
A zero value for the Conn.WriteControl deadline specifies no timeout, but the feature was implemented as a very long timeout (1000 hours). This PR updates the code to use no timeout when the deadline is zero. See the discussion in #895 for more details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
+ Coverage 71.30% 71.60% +0.30%
==========================================
Files 11 11
Lines 1589 1585 -4
==========================================
+ Hits 1133 1135 +2
+ Misses 349 345 -4
+ Partials 107 105 -2 ☔ View full report in Codecov by Sentry. |
|
A couple linting errors for 1.21. Not sure if they're relevant - haven't investigated deeply |
ghost
mentioned this pull request
1 task
AlexVulaj
approved these changes
Mar 6, 2024
|
The linter errors seem to be unrelated to me. Thanks for the contribution @GreenMarmot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
A zero value for the Conn.WriteControl deadline specifies no timeout, but the feature was implemented as a very long timeout (1000 hours). This PR updates the code to use no timeout when the deadline is zero.
See the discussion in #895 for more details.
Related Tickets & Documents
deadlineargument toWriteControlisdeadline.IsZero()then 1000 hours (~41 days) are used as unexpected and undocumented fallback #895Added/updated tests?
have not been included
Run verifications and test
make verifyis passing (error unrelated to this pr)make testis passing