Remove done channel in client-server echo example

[CicadaCinema]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

I don't believe anything is actually sent to the done channel, in this example there are only statements reading from it. Furthermore, the deferred close(done) statement will never execute because deferred statements in other goroutines are not run when main terminates. So no messages will ever be sent to this channel and it will never be closed, so it is safe to remove all the references to done.

I took a look at 844dd6d , where done was introduced, and the situation was similar then, so I believe this is an oversight in that commit.

Related Tickets & Documents

None

Added/updated tests?

• Yes
• No, and this is why: I only slightly modified some code in an example application, and the functionality remains unaffected so there is nothing more to test
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

I didn't run these ^ .

[CicadaCinema]

Nevermind, I realised that the goroutine will actually terminate due to an error coming from ReadMessage().