Cleanup remnants of net.Error Temporary() #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change to the package removed calls to the deprecated net.Error Temporary() method. This change removes the cruft left behind by that change. - Delete the hideTempError function. Because applications should not call net.Error Temporary() method, there's no need to force the Temporary() return value to false. - Replace the internal errWriteTimeout error with the standard os.ErrDeadlineExceeded. - Prior to the removing the calls to Temporary(), the default ping and close handlers ignored timeout errors by checking for net.Error Temporary() == true. The current code does not ignore timeout errors. Update the handlers to ignore timeout errors by checking for os.ErrDeadlineExceeded. Unrelated to the above: Reduce noise in the test output by ignoring the error from the compress/flate reader Close method.
Repository owner
closed this by deleting the head repository
Sep 19, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change to the package removed calls to the deprecated net.Error Temporary() method. This change removes the cruft left behind by that change.
Delete the hideTempError function. Because applications should not call net.Error Temporary() method, there's no need to force the Temporary() return value to false.
Replace the internal errWriteTimeout error with the standard os.ErrDeadlineExceeded.
Prior to the removing the calls to Temporary(), the default ping and close handlers ignored timeout errors by checking for net.Error Temporary() == true. The current code does not ignore timeout errors. Restore the code to ignore timeout errors by checking for os.ErrDeadlineExceeded.
Unrelated to the above: Reduce noise in the test output by ignoring the error from the compress/flate reader Close method.