Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed to use context.Context in TLS handshake #730

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 2 additions & 14 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,9 @@ func (d *Dialer) DialContext(ctx context.Context, urlStr string, requestHeader h

var err error
if trace != nil {
err = doHandshakeWithTrace(trace, tlsConn, cfg)
err = doHandshakeWithTrace(ctx, trace, tlsConn, cfg)
} else {
err = doHandshake(tlsConn, cfg)
err = doHandshake(ctx, tlsConn, cfg)
}

if err != nil {
Expand Down Expand Up @@ -381,15 +381,3 @@ func (d *Dialer) DialContext(ctx context.Context, urlStr string, requestHeader h
netConn = nil // to avoid close in defer.
return conn, resp, nil
}

func doHandshake(tlsConn *tls.Conn, cfg *tls.Config) error {
if err := tlsConn.Handshake(); err != nil {
return err
}
if !cfg.InsecureSkipVerify {
if err := tlsConn.VerifyHostname(cfg.ServerName); err != nil {
return err
}
}
return nil
}
21 changes: 21 additions & 0 deletions tls_handshake.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
//go:build go1.17
// +build go1.17

package websocket

import (
"context"
"crypto/tls"
)

func doHandshake(ctx context.Context, tlsConn *tls.Conn, cfg *tls.Config) error {
if err := tlsConn.HandshakeContext(ctx); err != nil {
return err
}
if !cfg.InsecureSkipVerify {
if err := tlsConn.VerifyHostname(cfg.ServerName); err != nil {
return err
}
}
return nil
}
21 changes: 21 additions & 0 deletions tls_handshake_116.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
//go:build !go1.17
// +build !go1.17

package websocket

import (
"context"
"crypto/tls"
)

func doHandshake(ctx context.Context, tlsConn *tls.Conn, cfg *tls.Config) error {
if err := tlsConn.Handshake(); err != nil {
return err
}
if !cfg.InsecureSkipVerify {
if err := tlsConn.VerifyHostname(cfg.ServerName); err != nil {
return err
}
}
return nil
}
6 changes: 4 additions & 2 deletions trace.go
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
//go:build go1.8
// +build go1.8

package websocket

import (
"context"
"crypto/tls"
"net/http/httptrace"
)

func doHandshakeWithTrace(trace *httptrace.ClientTrace, tlsConn *tls.Conn, cfg *tls.Config) error {
func doHandshakeWithTrace(ctx context.Context, trace *httptrace.ClientTrace, tlsConn *tls.Conn, cfg *tls.Config) error {
if trace.TLSHandshakeStart != nil {
trace.TLSHandshakeStart()
}
err := doHandshake(tlsConn, cfg)
err := doHandshake(ctx, tlsConn, cfg)
if trace.TLSHandshakeDone != nil {
trace.TLSHandshakeDone(tlsConn.ConnectionState(), err)
}
Expand Down
5 changes: 3 additions & 2 deletions trace_17.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !go1.8
// +build !go1.8

package websocket
Expand All @@ -7,6 +8,6 @@ import (
"net/http/httptrace"
)

func doHandshakeWithTrace(trace *httptrace.ClientTrace, tlsConn *tls.Conn, cfg *tls.Config) error {
return doHandshake(tlsConn, cfg)
func doHandshakeWithTrace(ctx context.Context, trace *httptrace.ClientTrace, tlsConn *tls.Conn, cfg *tls.Config) error {
return doHandshake(ctx, tlsConn, cfg)
}