Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to new homebrew constuctions (on_arm, on_intel) #4822

Merged
merged 1 commit into from May 2, 2024

Conversation

kvendingoldo
Copy link
Contributor

@kvendingoldo kvendingoldo commented May 1, 2024

...

Brew linter says that old constructions can't be used in case of submitting to brew-core

...

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 1, 2024
@caarlos0 caarlos0 merged commit b05a62f into goreleaser:main May 2, 2024
6 checks passed
@github-actions github-actions bot added this to the v1.26.0 milestone May 2, 2024
@caarlos0
Copy link
Member

caarlos0 commented May 2, 2024

thanks!

@caarlos0 caarlos0 added the enhancement New feature or request label May 2, 2024
@bartekpacia
Copy link
Contributor

bartekpacia commented May 6, 2024

This broke my build.

See commit to my homebrew tap: bartekpacia/homebrew-tools@ed22203

Commit in my project: bartekpacia/emu@cf3d1c5

GoReleaser version: v1.25.2-0.20240503132955-e538341179a2 (I use go install github.com/goreleaser/goreleaser@main)

Logs:

$ brew install emu
Error: bartekpacia/tools/emu: /opt/homebrew/Library/Taps/bartekpacia/homebrew-tools/Formula/emu.rb:59: syntax error, unexpected `end', expecting end-of-input
    end
    ^~~

bartekpacia added a commit to bartekpacia/emu that referenced this pull request May 6, 2024
Problem that forces me to do this: goreleaser/goreleaser#4822
caarlos0 added a commit that referenced this pull request May 6, 2024
refs #4822

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member

caarlos0 commented May 6, 2024

thanks @bartekpacia, should have been fixed in 14ab459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants