feat(depot): add depot image builder and pusher #4397
Draft
+98
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depot is a fast way to build and push docker images. Signed-off-by: Chris Goller <goller@gmail.com>
pull-request-size
bot
added
the
size/L
caarlos0
reviewed
Nov 8, 2023
pkg/config/config.go
Outdated
| @@ -1040,6 +1040,7 @@ type Docker struct { | |||
| BuildFlagTemplates []string `yaml:"build_flag_templates,omitempty" json:"build_flag_templates,omitempty"` | |||
| PushFlags []string `yaml:"push_flags,omitempty" json:"push_flags,omitempty"` | |||
| Use string `yaml:"use,omitempty" json:"use,omitempty" jsonschema:"enum=docker,enum=buildx,default=docker"` | |||
| DepotProject string `yaml:"depot_project,omitempty" json:"depot_project,omitempty"` | |||
There was a problem hiding this comment.
Assuming we might add more things later (either for depot or for something else), maybe something like:
dockers:
- use: depot
depot:
project: foowdyt?
Signed-off-by: Chris Goller <goller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depot is a fast way to build and push docker images.
This is my draft to add depot with minimal changes to the docker build and push.
The key difference compared to the existing docker code is that depot can both build
and push multi-platform images in one step.
This PR does some refactoring of the
imagerinterface to allow thebuildfunction to optionally returna digest that signifies the pushed image. I'm not sure if this is the right approach; let me know!
( no tests yet ... I'm not sure yet how to proceed as I think the tests
may need a refactor to accommodate simultaneous build and push)
So, this commit adds
use: depotto the docker builder allowing images to be build and pushed using depot.dev.Additionally, a new optional docker setting,
depot_project, can explicitly set the project.Note that the project can also be set via the env var,
DEPOT_PROJECT_IDor with a local file,depot.json.depot.dev is a hosted buildkit that is a fast way build and push multi-platform images.
Here is the ticket about depot: #3746