ci: test on windows #4293
Open
ci: test on windows #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/S
Deploying with
|
| Latest commit: |
802fb10
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0157eae7.goreleaser.pages.dev |
| Branch Preview URL: | https://windows-test-2.goreleaser.pages.dev |
Codecov Report
@@ Coverage Diff @@
## main #4293 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 132 132
Lines 12537 12543 +6
=======================================
+ Hits 10545 10551 +6
Misses 1587 1587
Partials 405 405
|
pull-request-size
bot
added
size/M
pull-request-size
bot
added
size/L
|
Just in case you didn't noticed yet, there's a long-standing issue with the Go testing package on Windows. Whenever a test uses t.TempDir(), the cleanup fails, and so does the test. This still affects the latest go 1.21.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding windows tests so I can better investigate some issues