Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple files with same name warning #3660

Merged
merged 1 commit into from Dec 23, 2022
Merged

fix: multiple files with same name warning #3660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/artifact/artifact.go
View file
Open in desktop
Expand Up @@ -294,11 +294,12 @@ func (artifacts Artifacts) List() []*Artifact {
if item.Name == "" {
continue
}
if names[item.Name] {
plat := item.Goos + item.Goarch + item.Goarm + item.Gomips + item.Goamd64
if names[item.Name+"_"+plat] {
log.WithField("name", item.Name).
Warn("multiple artifacts with the same name: this may cause errors")
}
names[item.Name] = true
names[item.Name+"_"+plat] = true
}
return artifacts.items
}
Expand Down