New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(brew): allow to template brew.install #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should not be needed in most cases, but doesn't hurt to make it work anyway. Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Nov 24, 2022
caarlos0
added
enhancement
New feature or request
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 24, 2022
2 tasks
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #3593 +/- ##
=======================================
Coverage 83.87% 83.88%
=======================================
Files 117 117
Lines 9751 9756 +5
=======================================
+ Hits 8179 8184 +5
Misses 1268 1268
Partials 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
cpanato
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are amazing
worked like a charm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be needed in most cases, but doesn't hurt to make it work anyway.
closes #3587