Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(brew): allow to template brew.install #3593

Merged
merged 5 commits into from Nov 25, 2022
Merged

feat(brew): allow to template brew.install #3593

merged 5 commits into from Nov 25, 2022

Conversation

caarlos0
Copy link
Member

Should not be needed in most cases, but doesn't hurt to make it work anyway.

closes #3587

Should not be needed in most cases, but doesn't hurt to make it work
anyway.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 24, 2022
@caarlos0 caarlos0 self-assigned this Nov 24, 2022
@caarlos0 caarlos0 added enhancement New feature or request and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:30 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:33 Inactive
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #3593 (395420c) into main (eedf957) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3593   +/-   ##
=======================================
  Coverage   83.87%   83.88%           
=======================================
  Files         117      117           
  Lines        9751     9756    +5     
=======================================
+ Hits         8179     8184    +5     
  Misses       1268     1268           
  Partials      304      304           
Impacted Files Coverage Δ
internal/pipe/brew/brew.go 83.44% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 23:15 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 23:20 Inactive
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are amazing

worked like a charm

@caarlos0 caarlos0 merged commit 541e3df into main Nov 25, 2022
@caarlos0 caarlos0 deleted the brew-tmp branch November 25, 2022 12:32
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support template in the install section for brews
2 participants