Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add windows to default builds #3581

Merged
merged 2 commits into from Nov 24, 2022
Merged

feat: add windows to default builds #3581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccdd70f
feat: add windows to default builds
jolheiser Nov 22, 2022
919b4ed
docs: add windows note to default build
jolheiser Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/builders/golang/build.go
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@ func (*Builder) WithDefaults(build config.Build) (config.Build, error) {
}
if len(build.Targets) == 0 {
if len(build.Goos) == 0 {
build.Goos = []string{"linux", "darwin"}
build.Goos = []string{"linux", "darwin", "windows"}
}
if len(build.Goarch) == 0 {
build.Goarch = []string{"amd64", "arm64", "386"}
Expand Down
9 changes: 9 additions & 0 deletions internal/builders/golang/build_test.go
View file
Open in desktop
Expand Up @@ -77,6 +77,9 @@ func TestWithDefaults(t *testing.T) {
"linux_arm64",
"darwin_amd64_v1",
"darwin_arm64",
"windows_amd64_v1",
"windows_arm64",
"windows_386",
},
goBinary: "go",
},
Expand Down Expand Up @@ -167,6 +170,9 @@ func TestWithDefaults(t *testing.T) {
"linux_arm64",
"darwin_amd64_v1",
"darwin_arm64",
"windows_amd64_v1",
"windows_arm64",
"windows_386",
},
goBinary: "go",
},
Expand All @@ -182,6 +188,9 @@ func TestWithDefaults(t *testing.T) {
"linux_arm64",
"darwin_amd64_v1",
"darwin_arm64",
"windows_amd64_v1",
"windows_arm64",
"windows_386",
},
goBinary: "go",
},
Expand Down
4 changes: 2 additions & 2 deletions internal/pipe/build/build_test.go
View file
Open in desktop
Expand Up @@ -275,7 +275,7 @@ func TestDefaultEmptyBuild(t *testing.T) {
require.Equal(t, ctx.Config.ProjectName, build.Binary)
require.Equal(t, ".", build.Dir)
require.Equal(t, ".", build.Main)
require.Equal(t, []string{"linux", "darwin"}, build.Goos)
require.Equal(t, []string{"linux", "darwin", "windows"}, build.Goos)
require.Equal(t, []string{"amd64", "arm64", "386"}, build.Goarch)
require.Equal(t, []string{"6"}, build.Goarm)
require.Equal(t, []string{"hardfloat"}, build.Gomips)
Expand Down Expand Up @@ -373,7 +373,7 @@ func TestDefaultPartialBuilds(t *testing.T) {
require.Equal(t, "foo", build.Binary)
require.Equal(t, ".", build.Main)
require.Equal(t, "baz", build.Dir)
require.Equal(t, []string{"linux", "darwin"}, build.Goos)
require.Equal(t, []string{"linux", "darwin", "windows"}, build.Goos)
require.Equal(t, []string{"386"}, build.Goarch)
require.Equal(t, []string{"6"}, build.Goarm)
require.Len(t, build.Ldflags, 1)
Expand Down
2 changes: 1 addition & 1 deletion www/docs/customization/build.md
View file
Open in desktop
Expand Up @@ -77,7 +77,7 @@ builds:

# GOOS list to build for.
# For more info refer to: https://golang.org/doc/install/source#environment
# Defaults are darwin and linux.
# Defaults are darwin, linux, and windows.
goos:
- freebsd
- windows
Expand Down