New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: handle mixing of job and normal tokens #3415
bugfix: handle mixing of job and normal tokens #3415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor style stuff, lgtm otherwise!
thanks
Codecov Report
@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
+ Coverage 83.87% 83.89% +0.02%
==========================================
Files 115 115
Lines 9219 9233 +14
==========================================
+ Hits 7732 7746 +14
Misses 1210 1210
Partials 277 277
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
…oreleaser into bugfix-ci-token-brew-push
Ty for the suggestions, teaching me all sorts of new things, much appreciated!! New code is up now |
thank you for the fix! 🙏 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If applied, this commit will allow for new GitLab clients to use both ci job tokens and plain tokens (for things like brew publishing where the CI_JOB_TOKEN isn't applicable)
This provides a fix for #3399
closes #3399