Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate draft release in GitHub #3149

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
83 changes: 76 additions & 7 deletions internal/client/github.go
Expand Up @@ -221,13 +221,27 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string,
data.DiscussionCategoryName = github.String(ctx.Config.Release.DiscussionCategoryName)
}

release, _, err = c.client.Repositories.GetReleaseByTag(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
data.GetTagName(),
)
if err != nil {
if *data.Draft {
release, err = c.getExistedDraftRelease(ctx, data)
if err != nil {
return "", err
}
if release != nil {
err = c.deleteExistedDraftReleaseAssets(ctx, release.GetID())
if err != nil {
return "", err
}
}
} else {
release, _, _ = c.client.Repositories.GetReleaseByTag(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
data.GetTagName(),
)
}

if release == nil {
release, _, err = c.client.Repositories.CreateRelease(
ctx,
ctx.Config.Release.GitHub.Owner,
Expand Down Expand Up @@ -357,3 +371,58 @@ func overrideGitHubClientAPI(ctx *context.Context, client *github.Client) error

return nil
}

func (c *githubClient) getExistedDraftRelease(ctx *context.Context, release *github.RepositoryRelease) (*github.RepositoryRelease, error) {
opt := github.ListOptions{PerPage: 50}
for {
releases, resp, err := c.client.Repositories.ListReleases(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
&opt,
)
if err != nil {
return nil, err
}
for _, r := range releases {
if *r.Draft && *r.Name == *release.Name {
return r, nil
}
}
if resp.NextPage == 0 {
return nil, nil
}
opt.Page = resp.NextPage
}
}

func (c *githubClient) deleteExistedDraftReleaseAssets(ctx *context.Context, releaseID int64) error {
opt := github.ListOptions{PerPage: 50}
for {
assets, resp, err := c.client.Repositories.ListReleaseAssets(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
releaseID,
&opt,
)
if err != nil {
return err
}
for _, a := range assets {
_, err := c.client.Repositories.DeleteReleaseAsset(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
a.GetID(),
)
if err != nil {
return err
}
}
if resp.NextPage == 0 {
return nil
}
opt.Page = resp.NextPage
}
}