Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: archive should not actually verify links #3103

Merged
merged 1 commit into from May 13, 2022
Merged

Conversation

caarlos0
Copy link
Member

This seems to be the way tar et al works... if you give it a folder with a symlink pointing to nowhere, it will archive that symbolic link no question asked.

we should probably do the same, specially given #3102

IMHO not a breaking change, as someone with bad links wont be able to archive things in the current version of goreleaser.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label May 12, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3103 (16aa368) into main (9c426a7) will increase coverage by 0.00%.
The diff coverage is 53.84%.

@@           Coverage Diff           @@
##             main    #3103   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         113      113           
  Lines        9295     9298    +3     
=======================================
+ Hits         7846     7849    +3     
  Misses       1176     1176           
  Partials      273      273           
Impacted Files Coverage Δ
pkg/archive/tar/tar.go 81.63% <40.00%> (ø)
pkg/archive/zip/zip.go 79.54% <62.50%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c426a7...16aa368. Read the comment docs.

@caarlos0 caarlos0 merged commit 0db84b2 into main May 13, 2022
@caarlos0 caarlos0 deleted the archive-symbolic-links branch May 13, 2022 16:55
@github-actions github-actions bot added this to the v1.9.0 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant