Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: evaluate archive files in another package #3101

Merged
merged 2 commits into from May 12, 2022
Merged

Conversation

caarlos0
Copy link
Member

will be used in #2911

would be used in #2911

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label May 12, 2022
@caarlos0 caarlos0 self-assigned this May 12, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2022
@vercel vercel bot temporarily deployed to Preview May 12, 2022 01:18 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 12, 2022 01:42 Inactive
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3101 (5230021) into main (5d9110a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3101   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         112      113    +1     
  Lines        9295     9295           
=======================================
  Hits         7846     7846           
  Misses       1176     1176           
  Partials      273      273           
Impacted Files Coverage Δ
internal/archivefiles/archivefiles.go 100.00% <100.00%> (ø)
internal/pipe/archive/archive.go 93.57% <100.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9110a...5230021. Read the comment docs.

@caarlos0 caarlos0 merged commit 9c426a7 into main May 12, 2022
@caarlos0 caarlos0 deleted the archive-refs branch May 12, 2022 01:56
@github-actions github-actions bot added this to the v1.9.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant