Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed #3058 issue #3060

Closed
wants to merge 2 commits into from
Closed

Conversation

quenbyako
Copy link

This commit is a fix for #3058 issue, when goreleaser thinks that in git remote url any path with less than 2 items is an invalid url.

Why is this change being made: To support exotic git engines like Gerrit, since git is not providing any limitations to repository url.

No any additional tests needed, it's just a fix to minimum value

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2022
@quenbyako
Copy link
Author

I see that one test is failed, need to fix it

caarlos0 added a commit that referenced this pull request May 9, 2022
basically allows to use goreleaser against a repo with a git url without both owner and repo name.

closes #3060
closes #3058

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
Copy link
Member

caarlos0 commented May 9, 2022

more complete fix: #3088

@caarlos0 caarlos0 closed this May 9, 2022
caarlos0 added a commit that referenced this pull request May 9, 2022
basically allows to use goreleaser against a repo with a git url without both owner and repo name.

closes #3060
closes #3058

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants