Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitlab option to use_job_token #2993

Merged
merged 2 commits into from Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/client/gitlab.go
Expand Up @@ -44,7 +44,14 @@ func NewGitLab(ctx *context.Context, token string) (Client, error) {

options = append(options, gitlab.WithBaseURL(apiURL))
}
client, err := gitlab.NewClient(token, options...)

var client *gitlab.Client
var err error
if ctx.Config.GitLabURLs.UseJobToken {
client, err = gitlab.NewJobClient(token, options...)
} else {
client, err = gitlab.NewClient(token, options...)
}
if err != nil {
return &gitlabClient{}, err
}
Expand Down
1 change: 1 addition & 0 deletions pkg/config/config.go
Expand Up @@ -30,6 +30,7 @@ type GitLabURLs struct {
Download string `yaml:"download,omitempty" json:"download,omitempty"`
SkipTLSVerify bool `yaml:"skip_tls_verify,omitempty" json:"skip_tls_verify,omitempty"`
UsePackageRegistry bool `yaml:"use_package_registry,omitempty" json:"use_package_registry,omitempty"`
UseJobToken bool `yaml:"use_job_token,omitempty" json:"use_job_token,omitempty"`
}

// GiteaURLs holds the URLs to be used when using gitea.
Expand Down
5 changes: 5 additions & 0 deletions www/docs/scm/gitlab.md
Expand Up @@ -30,11 +30,16 @@ You can use GoReleaser with GitLab Enterprise by providing its URLs in the
gitlab_urls:
api: https://gitlab.mycompany.com/api/v4/
download: https://gitlab.company.com

# set to true if you use a self-signed certificate
skip_tls_verify: false

# set to true if you want to upload to the Package Registry rather than attachments
# Only works with GitLab 13.5+
use_package_registry: false

# Set this if you set GITLAB_TOKEN to the value of CI_JOB_TOKEN:
use_job_token: true
```

If none are set, they default to GitLab's public URLs.
Expand Down