fix: build breaking on windows 386 #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the set lib was trowing an int overflow error on snapshot when there are no binary artifacts to sign. Refs #2839 See https://github.com/goreleaser/goreleaser/runs/5334854323?check_suite_focus=true#step:21:50 Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
pull-request-size
bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## main #2938 +/- ##
=======================================
Coverage 84.42% 84.42%
=======================================
Files 111 111
Lines 8974 8975 +1
=======================================
+ Hits 7576 7577 +1
Misses 1124 1124
Partials 274 274
Continue to review full report at Codecov.
|
|
curious! I've never seen an issue like that with |
wagoodman
approved these changes
Feb 25, 2022
caarlos0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the set lib was trowing an int overflow error on snapshot when there are no binary artifacts to sign.
This list is small, we don't need to worry about allocations et al, so I just switched it for a
mapfor now, which seems to fix the issue...cc @wagoodman
Refs #2839
See https://github.com/goreleaser/goreleaser/runs/5334854323?check_suite_focus=true#step:21:50