Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not copy binary by default #2916

Merged
merged 2 commits into from Feb 19, 2022
Merged

fix: do not copy binary by default #2916

merged 2 commits into from Feb 19, 2022

Conversation

caarlos0
Copy link
Member

closes #2913

@caarlos0
fix: do not copy binary by default
7da89e2 
closes #2913

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Feb 17, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2022
@vercel vercel bot temporarily deployed to Preview February 17, 2022 13:08 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Feb 17, 2022
@caarlos0 caarlos0 marked this pull request as ready for review February 17, 2022 13:08
@caarlos0
chore: ref
2b9a52e 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview February 17, 2022 13:09 Inactive
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #2916 (2b9a52e) into main (14edcd3) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2916      +/-   ##
==========================================
- Coverage   84.49%   84.39%   -0.11%     
==========================================
  Files         111      111              
  Lines        8903     8903              
==========================================
- Hits         7523     7514       -9     
- Misses       1109     1118       +9     
  Partials      271      271
Impacted Files Coverage Δ
cmd/build.go 91.72% <66.66%> (-6.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14edcd3...2b9a52e. Read the comment docs.

dirien
dirien approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit d6813ce into main Feb 19, 2022
@caarlos0 caarlos0 deleted the build branch February 19, 2022 18:10
@github-actions github-actions bot added this to the v1.6.0 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

New --output flag should be optional
2 participants
@caarlos0 @dirien