New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add id to dockers and docker_manifests #2399
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/goreleaser/DtpiTiuceFMDE1DDaAvEP7LaYAco |
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
- Coverage 82.92% 82.87% -0.05%
==========================================
Files 83 83
Lines 6060 6080 +20
==========================================
+ Hits 5025 5039 +14
- Misses 887 891 +4
- Partials 148 150 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Seems fairly simple.
Extra: map[string]interface{}{}, | ||
} | ||
if docker.ID != "" { | ||
art.Extra["ID"] = docker.ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity why do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the field used by the ids
filters later...
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #2398