Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple files with same name warning #3660

Merged
merged 1 commit into from Dec 23, 2022
Merged

fix: multiple files with same name warning #3660

merged 1 commit into from Dec 23, 2022

Conversation

caarlos0
Copy link
Member

the warning was too trigger happy, this should fix it.

thanks @ioga for reporting it.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Dec 23, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #3660 (b4da7b5) into main (8985606) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3660   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files         118      118           
  Lines        9874     9875    +1     
=======================================
+ Hits         8254     8255    +1     
  Misses       1306     1306           
  Partials      314      314           
Impacted Files Coverage Δ
internal/artifact/artifact.go 85.42% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 46fdb55 into main Dec 23, 2022
@caarlos0 caarlos0 deleted the fix-warn branch December 23, 2022 14:17
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant