Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows to default builds #3581

Merged
merged 2 commits into from Nov 24, 2022
Merged

Conversation

jolheiser
Copy link
Contributor

Resolves #3579

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #3581 (919b4ed) into main (090365b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3581   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         117      117           
  Lines        9750     9750           
=======================================
  Hits         8178     8178           
  Misses       1268     1268           
  Partials      304      304           
Impacted Files Coverage Δ
internal/builders/golang/build.go 79.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you @jolheiser !

I'll merge it in a couple of days 🙏

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 24, 2022
@caarlos0 caarlos0 merged commit b665685 into goreleaser:main Nov 24, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 24, 2022
@jolheiser jolheiser deleted the windows branch December 21, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build by default
2 participants