Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow git remote urls from non-scm sources #3088

Merged
merged 1 commit into from May 9, 2022
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 9, 2022

basically allows to use goreleaser against a repo with a git url without both owner and repo name.

closes #3060
closes #3058

basically allows to use goreleaser against a repo with a git url without both owner and repo name.

closes #3060
closes #3058

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2022
@vercel vercel bot temporarily deployed to Preview May 9, 2022 01:18 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label May 9, 2022
@caarlos0 caarlos0 requested a review from mavogel May 9, 2022 01:18
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3088 (40b31ae) into main (e290270) will increase coverage by 0.10%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   84.29%   84.39%   +0.10%     
==========================================
  Files         112      112              
  Lines        9250     9285      +35     
==========================================
+ Hits         7797     7836      +39     
+ Misses       1178     1176       -2     
+ Partials      275      273       -2     
Impacted Files Coverage Δ
internal/pipe/changelog/changelog.go 90.87% <0.00%> (+0.21%) ⬆️
internal/git/config.go 90.56% <82.35%> (-2.30%) ⬇️
internal/pipe/milestone/milestone.go 83.63% <100.00%> (+0.61%) ⬆️
internal/pipe/release/release.go 92.77% <100.00%> (+4.23%) ⬆️
pkg/config/config.go 88.83% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e290270...40b31ae. Read the comment docs.

@quenbyako
Copy link

By looking on code, that's exactly what i want, thank you so much! I'll check it on next workday, is it works for us, thaks a lot!

@quenbyako
Copy link

@caarlos0 You rock!!! 🤘🤘🤘🤘 Thank you so much, it's working as expected, +1 company which uses goreleaser 🥳🎉

@caarlos0 caarlos0 merged commit 53b1ee0 into main May 9, 2022
@caarlos0 caarlos0 deleted the allow-invalid-url branch May 9, 2022 12:32
@github-actions github-actions bot added this to the v1.9.0 milestone May 9, 2022
@chadgrant
Copy link

configuration is invalid: unsupported repository URL: ***github.com//xxxx/yyy currently getting double slashes in github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some custom git engines are not supported
3 participants