Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New --output flag should be optional #2913

Closed
2 tasks done
dkoshkin opened this issue Feb 16, 2022 · 0 comments · Fixed by #2916
Closed
2 tasks done

New --output flag should be optional #2913

dkoshkin opened this issue Feb 16, 2022 · 0 comments · Fixed by #2916
Assignees
@caarlos0
Labels
enhancement New feature or request
Milestone
v1.6.0

Comments

@dkoshkin
Copy link

Is your feature request related to a problem? Please describe.

This PR #2701 introduced a new --output flag but it defaults to the local directory.
We already generate binaries into the dist/ directory, it would be great to skip this new behavior.

Describe the solution you'd like

Instead of defaulting to the local directory when --output is not specified it should present the previous behavior and not copy the binary.

Describe alternatives you've considered

Setting --output=dist/ but it would still unnecessarily copy files around.

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response
@dkoshkin dkoshkin added enhancement New feature or request triage Issue pending triage by one of the maintainers labels Feb 16, 2022
caarlos0 added a commit that referenced this issue Feb 17, 2022
@caarlos0
fix: do not copy binary by default
7da89e2 
closes #2913

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 mentioned this issue Feb 17, 2022
Merged
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Feb 17, 2022
@caarlos0 caarlos0 added this to the v1.6.0 milestone Feb 17, 2022
caarlos0 added a commit that referenced this issue Feb 19, 2022
@caarlos0
fix: do not copy binary by default (#2916)
d6813ce 
* fix: do not copy binary by default

closes #2913

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

* chore: ref

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

fix: do not copy binary by default goreleaser/goreleaser
2 participants
@caarlos0 @dkoshkin