fix: nfpm replacements deprecation (#3793)

closes #3792 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
goreleaser · Feb 22, 2023 · 1858bac · 1858bac
1 parent 2c80588
commit 1858bac
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/internal/pipe/nfpm/nfpm.go b/internal/pipe/nfpm/nfpm.go
@@ -62,6 +62,11 @@ func (Pipe) Default(ctx *context.Context) error {
 		if len(fpm.Replacements) != 0 {
 			deprecate.Notice(ctx, "nfpms.replacements")
 		}
+		for _, rfpm := range fpm.Overrides {
+			if len(rfpm.Replacements) != 0 {
+				deprecate.Notice(ctx, "nfpms.replacements")
+			}
+		}
 		ids.Inc(fpm.ID)
 	}
 

diff --git a/internal/pipe/nfpm/nfpm_test.go b/internal/pipe/nfpm/nfpm_test.go
@@ -36,6 +36,42 @@ func TestRunPipeNoFormats(t *testing.T) {
 	testlib.AssertSkipped(t, Pipe{}.Run(ctx))
 }
 
+func TestDefaultsDeprecated(t *testing.T) {
+	t.Run("replacements", func(t *testing.T) {
+		ctx := context.New(config.Project{
+			NFPMs: []config.NFPM{
+				{
+					NFPMOverridables: config.NFPMOverridables{
+						Replacements: map[string]string{
+							"linux": "Tux",
+						},
+					},
+				},
+			},
+		})
+		require.NoError(t, Pipe{}.Default(ctx))
+		require.True(t, ctx.Deprecated)
+	})
+
+	t.Run("replacements overrides", func(t *testing.T) {
+		ctx := context.New(config.Project{
+			NFPMs: []config.NFPM{
+				{
+					Overrides: map[string]config.NFPMOverridables{
+						"apk": {
+							Replacements: map[string]string{
+								"linux": "Tux",
+							},
+						},
+					},
+				},
+			},
+		})
+		require.NoError(t, Pipe{}.Default(ctx))
+		require.True(t, ctx.Deprecated)
+	})
+}
+
 func TestRunPipeError(t *testing.T) {
 	ctx := context.New(config.Project{
 		Dist: t.TempDir(),