fix: switch lib to parse yaml #414
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 67.18% 67.69% +0.50%
==========================================
Files 3 3
Lines 128 130 +2
Branches 22 23 +1
==========================================
+ Hits 86 88 +2
+ Misses 27 26 -1
- Partials 15 16 +1
|
crazy-max
force-pushed
the
fix-yaml-parsing
branch
from
b37c79a
to
0d8dcf3
Compare
|
i wonder if it isn't simpler to let the user set the dist folder in the action too, and not even bother parsing any yaml 🙇♂️ |
caarlos0
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #397
Switch to
yamllib to properly parse goreleaser config.