fix: platform detection #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 4 4
Lines 92 92
Branches 17 17
=======================================
Hits 79 79
Misses 6 6
Partials 7 7
Continue to review full report at Codecov.
|
caarlos0
approved these changes
Aug 26, 2021
crazy-max
force-pushed
the
fix-platform
branch
from
ede4161
to
28fe8ac
Compare
crazy-max
force-pushed
the
fix-platform
branch
from
28fe8ac
to
b3eddb8
Compare
|
@crazy-max Thanks so much for the quick fix! I just tried it with |
tenyo
reviewed
Aug 26, 2021
| @@ -47,7 +47,7 @@ export async function getGoReleaser(distribution: string, version: string): Prom | |||
|
|
|||
| const getFilename = (distribution: string): string => { | |||
| const platform: string = osPlat == 'win32' ? 'Windows' : osPlat == 'darwin' ? 'Darwin' : 'Linux'; | |||
| const arch: string = osArch == 'x64' ? 'x86_64' : 'i386'; | |||
| const arch: string = osArch == 'x64' ? 'x86_64' : 'x32' ? 'i386' : osArch; | |||
There was a problem hiding this comment.
I think this should be
const arch: string = osArch == 'x64' ? 'x86_64' : osArch == 'x32' ? 'i386' : osArch;
tenyo
reviewed
Aug 26, 2021
| @@ -246,7 +246,7 @@ function getGoReleaser(distribution, version) { | |||
| exports.getGoReleaser = getGoReleaser; | |||
| const getFilename = (distribution) => { | |||
| const platform = osPlat == 'win32' ? 'Windows' : osPlat == 'darwin' ? 'Darwin' : 'Linux'; | |||
| const arch = osArch == 'x64' ? 'x86_64' : 'i386'; | |||
| const arch = osArch == 'x64' ? 'x86_64' : true ? 'i386' : 0; | |||
There was a problem hiding this comment.
You can see here it just evaluated the 'x32' to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
cc @tenyo