Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize validator #442

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: optimize validator #442

wants to merge 1 commit into from

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Mar 16, 2024

Closes #

📑 Description

此 PR 将之前位于各 HTTP 驱动中的 filter 调用挪至框架验证器部分,并优化了一个测试用例。

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@devhaozi devhaozi requested a review from hwbrzzl March 16, 2024 17:19
@devhaozi devhaozi enabled auto-merge (squash) March 16, 2024 17:19
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.59%. Comparing base (60102dd) to head (6a3a851).

Files Patch % Lines
validation/options.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   71.61%   71.59%   -0.02%     
==========================================
  Files         167      167              
  Lines       10134    10136       +2     
==========================================
  Hits         7257     7257              
- Misses       2317     2318       +1     
- Partials      560      561       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devhaozi
Copy link
Member Author

devhaozi commented Mar 16, 2024

测试中发现一个上级 bug,已经提交 issue:gookit/validate#262

这个 PR 可以先放着不合并

@devhaozi devhaozi disabled auto-merge March 16, 2024 18:04
@devhaozi devhaozi marked this pull request as draft May 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant