Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[watchmedo] Avoid zombie sub-processes when running shell-command without --wait #897

Merged
merged 9 commits into from Jun 8, 2022
Merged

[watchmedo] Avoid zombie sub-processes when running shell-command without --wait #897

merged 9 commits into from Jun 8, 2022

Commits on Jun 6, 2022

  1. [watchmedo] Avoid zombie sub-processes when running shell-command wit… 

    …hout --wait
    @taleinat
    taleinat committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    e933df8 View commit details
    Browse the repository at this point in the history

  2. lint

    @taleinat
    taleinat committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    d05bf7d View commit details
    Browse the repository at this point in the history

  3. reference the issue rather than PR in the changelog

    @taleinat
    taleinat committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    1039437 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. avoid shlex.join which was added in Python 3.8

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    90d6219 View commit details
    Browse the repository at this point in the history

  2. increase test wait time

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    9b58cf3 View commit details
    Browse the repository at this point in the history

  3. try further increasing wait time to get tests passing on Windows

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    2b9b28a View commit details
    Browse the repository at this point in the history

  4. fix is_process_running()

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    d221032 View commit details
    Browse the repository at this point in the history

  5. still debugging on Windows...

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b2dd1e5 View commit details
    Browse the repository at this point in the history

  6. apparently Windows doesn't like shell-quoted Python executables

    @taleinat
    taleinat committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    18b15d0 View commit details
    Browse the repository at this point in the history