Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse auto-restart's --kill-after parameter as a float #886

Merged

Conversation

taleinat
Copy link
Contributor

This appears to be the originally intended behavior.

Fixes #870.

This appears to be the originally intended behavior.
@BoboTiG
Copy link
Collaborator

BoboTiG commented May 12, 2022

Thanks @taleinat !

Do you mind adding a line, and your nickname, in the changelog?

@BoboTiG
Copy link
Collaborator

BoboTiG commented May 12, 2022

(Do not check failing tests, they are flaky.)

@taleinat
Copy link
Contributor Author

Sure, just a minute...

@taleinat
Copy link
Contributor Author

Do you mind adding a line, and your nickname, in the changelog?

Done.

@BoboTiG BoboTiG merged commit 030fb0a into gorakhargosh:master May 12, 2022
@BoboTiG
Copy link
Collaborator

BoboTiG commented May 12, 2022

Thanks a lot for your first contribution @taleinat 🍾 :)

@taleinat taleinat deleted the fix-auto-restart-kill-after-parsing branch May 12, 2022 19:22
@taleinat
Copy link
Contributor Author

Thanks for all of your work on watchdog, @BoboTiG! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watchmedo - argparse for --kill-after needs to be a float
2 participants