win32 fixes to avoid unix only apis in tricks/__init__.py

[replabrobin]

OK I have toxed this in linux, but I will need time to check the changes in windows 10

[BoboTiG]

I just saw that watchmedo tests are near to zero. Do you think you could add simple test(s) to cover your changes?

[replabrobin]

Hi I'm not really certain how one should test this; I used the following code

def make_dummy_script(tmpdir, n=10):
	script = os.path.join(tmpdir, 'auto-test-%d.py' % n)
	with open(script, 'w') as f:
		f.write('import time\nfor i in range(%d):\n\tprint("+++++ %%d" %% i)\n\ttime.sleep(1)\n' % n)
	return script


def test_kill_auto_restart(tmpdir):
	from watchdog.tricks import AutoRestartTrick
	import sys
	import time
	script = make_dummy_script(tmpdir)
	try:
		a = AutoRestartTrick([sys.executable, script])
		a.start()
		time.sleep(5)
		a.stop()
	finally:
		os.remove(script)

but as a person who doesn't normally use Tox I don't know to test that the kill actually stops the task in the middle. There was no error and the test said it passed, but I would like to check that we didn't get to "+++++ 9" in the output.

EDIT: apparently I need to start messing with pytest capsys plugin. I will take a few moments to figure out what to do.

[BoboTiG]

Thanks a lot for the test, really appreciated!

[replabrobin]

Not sure why these errors are so random. I tried in a forked rep and got different failures :(

[BoboTiG]

Random failures are OK as soon as the new test passes on Windows.

[replabrobin]

I'm not windows savvy any more. I will have to try and run these on a windows 10 laptop and see if we never get the KeyboardInterrupt appearing in the subprocess output.

[replabrobin]

OK tried various tricks to get the stderr from the subprocess and in windows it doesn't work. So the easiest is to just drop the requirement that the right exception is seen.

[BoboTiG]

That's good for me, thanks @replabrobin 🍾

[replabrobin]

Thanks BoboTiG; I'm never sure about the git philosophy here. Should I leave the branch in place in my repo or delete it or delete the whole repo? What's the 'right/nice' way?

[BoboTiG]

As you have another PR, it is a good practice to only delete the branch since it was merged.
You could delete the whole repository when all your PRs will be either merged either closed (or you can keep the repository alive, it is up to you).