[windows] winapi.BUFFER_SIZE now defaults to 64000 (instead of 2048) #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle cases with lot of changes, this seems the highest safest value we can use.
Note: it will fail with `ERROR_INVALID_PARAMETER` when it is greater than 64 KB and
the application is monitoring a directory over the network.
This is due to a packet size limitation with the underlying file sharing protocols.
https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-readdirectorychangesw#remarks
Also introduced `winapi.PATH_BUFFER_SIZE` (defaults to `2048`)
to keep the old behavior with path-realted functions.
BoboTiG
force-pushed
the
fix-700-higher-buffer-len
branch
from
00d5fc9
to
16854eb
Compare
|
cf #264. |
|
Hello @BoboTiG Experiencing a similar issue with the latest version of watchdog. Setup
|
@Elwycliffs did you manage to find a fix for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle cases with lot of changes, this seems the highest safest value we can use.
Note: it will fail with
ERROR_INVALID_PARAMETERwhen it is greater than 64 KB and the application is monitoring a directory over the network. This is due to a packet size limitation with the underlying file sharing protocols. https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-readdirectorychangesw#remarksAlso introduced
winapi.PATH_BUFFER_SIZE(defaults to2048) to keep the old behavior with path-related functions.