Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle SIGTERM more gracefully in watchmedo #693

Merged
merged 2 commits into from
Oct 22, 2020
Merged

fix: Handle SIGTERM more gracefully in watchmedo #693

merged 2 commits into from
Oct 22, 2020

Commits on Oct 21, 2020

  1. fix: Handle repeated signals better in watchmedo 

    This fixes misbehaviour where the child process could be orphaned if
watchmedo received multiple non-fatal signals causing the
`handler.stop()` call to be interrupted or never occur. By raising a
semantic exception after neutering the relevant signals, we give
ourselves a better chance of killing the child.

Fixes gorakhargosh#543
    @maybe-sybr
    maybe-sybr committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    2cc0dc0 View commit details
    Browse the repository at this point in the history

  2. doc: Use finally for teardown in doco examples 

    This should encourage better handling of non-^C exit conditions in API
based use.
    @maybe-sybr
    maybe-sybr committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    9c0dfb9 View commit details
    Browse the repository at this point in the history