fix: Separate MapView disposal from LifecycleOwner changes #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSteve595
changed the title
|
Will this be merged? I need this fix |
|
@DSteve595 great find. Thank you! |
|
@thekingrenz23 A release will be made shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#206 introduced a crash when disposing the MapView, as reported in #207. Since the
DisposableEffecthas multiple keys, changes to any of them will result in the MapView becoming destroyed, which is not necessarily what we want. This repro project (extremely helpful, thank you @thekingrenz23!) revealed a case where the lifecycle owner (one of the DisposableEffect keys) can change without changing the MapView or context. This puts the MapView into a bad state, where it's "destroyed" but still shown and fully interactible.This moves the MapView disposal into its own DisposableEffect with only the MapView as a key, avoiding the unwanted disposal.
Fixes #207 馃