fix: Prevent a memory leak on AndroidView which may not call ON_DESTROY #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wangela
approved these changes
Sep 22, 2022
googlemaps-bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
## [2.7.2](v2.7.1...v2.7.2) (2022-09-22) ### Bug Fixes * Prevent a memory leak on AndroidView which may not call ON_DESTROY ([#206](#206)) ([7130698](7130698))
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
v2.7.2 containing this fix has been released to Maven. Thank you for your contribution @polivmi1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak that can happen in AndroidView when navigating to another screen.
The Lifecycle ON_DESTROY event is never called because in onDispose we remove the mapLifecycleObserver and this method is called before the Lifecycle ON_DESTROY event. It will correct the problem that occurred in #188
We have to handle any Lifecycle ON_DESTROY in the onDispose method.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #138 🦕