Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GoogleMap breaking preview mode. #179

Merged
merged 1 commit into from Jul 15, 2022
Merged

fix: GoogleMap breaking preview mode. #179

merged 1 commit into from Jul 15, 2022

Conversation

arriolac
Copy link
Member

Fix preview mode by checking if the GoogleMap composable was invoked within a preview. This allows previews to be shown
for other UI elements, but, the map will still not be rendered.

Fixes #128 馃

Change-Id: I033c5878304639dc22107f7e540496ee564d9c2c
Copy link
Contributor

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arriolac! LGTM. Tests pass locally for me, and it looks like the CI is failing with the same flaky test discussed in PR #180, so we can merge.

@barbeau barbeau merged commit 919b0cc into main Jul 15, 2022
@barbeau barbeau deleted the chris/fix/128 branch July 15, 2022 17:40
googlemaps-bot pushed a commit that referenced this pull request Jul 15, 2022
## [2.5.3](v2.5.2...v2.5.3) (2022-07-15)

### Bug Fixes

* GoogleMap breaking preview mode. ([#179](#179)) ([919b0cc](919b0cc))
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 2.5.3 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview for GoogleMap Composable
3 participants