GoogleMap Composable breaks layout in Preview

[claytongreen]

A previous issue #128 and pull request #179 fix the Compose preview breaking when using a GoogleMap composable.
But the layout in the preview is still incorrect as any of the modifiers passed to the GoogleMap are discarded with the early return.

For example:

Column(Modifier.fillMaxSize()) {
    GoogleMap(Modifier.weight(1f))
    SomeExampleContent()
}

A possible fix could be instead of a bare return when in preview, GoogleMap could return a Box that keeps the modifiers.

// When in preview, early return a Box with the received modifier preserving layout
if (LocalInspectionMode.current) {
    return Box(modifier = modifier)
}

I have a commit (7e103f5) ready to go, but the pull request said to make an issue first.

Thanks

[arriolac]

@claytongreen that's how I would fix it, too. Feel free to open a pull request with that fix.

[wangela]

Since this changes the return type, do users of this library have to change their code when using the GoogleMap composable? i.e., is it a breaking change?

[arriolac]

Ah yeah it should be:

// When in preview, early return a Box with the received modifier preserving layout
if (LocalInspectionMode.current) {
    Box(modifier = modifier)
    return
}

[claytongreen]

Good catch!
Change has been pushed

[googlemaps-bot]

🎉 This issue has been resolved in version 2.7.3 🎉

The release is available on:

• v2.7.3
• GitHub release

Your semantic-release bot 📦🚀