Make: package_version less brittle #675
Conversation
There is no easy / cross platform way to get at the local crate's version, so we are doing some grepping, since we can assume grep is installed on local machines. This change makes the grep pipeline less brittle by looking for the `name="quilkin"` block first before grepping for the version details. Unblocks googleforgames#670
markmandel
added
kind/cleanup
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
|
Build Succeeded 🥳 Build Id: b3b0b2a9-6921-4cde-9528-f12f6179cae9 The following development images have been built, and will exist for the next 30 days: To build this version: |
If we're willing to depend on |
I thought about this, but I wasn't feeling very comfortable assuming people had jq installed, and making it a hard dependency for building Quilkin artifacts. Whereas I feel way more comfortable with grep/awk being locally installed. I tried to also run |
googleforgames#675 was better than the original, but still potentially brittle if the format of the Cargo.toml changed. This is better than googleforgames#675, since gets the value from a `cargo` command, so it no longer matters if the Cargo.toml changes -- everything should still work as always, since it's a format. We are also now only relying on `cargo` and `awk` as dev dependencies, which is actually one less dependency than before (grep).
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
There is no easy / cross platform way to get at the local crate's version, so we are doing some grepping, since we can assume grep is installed on local machines.
This change makes the grep pipeline less brittle by looking for the
name="quilkin"block first before grepping for the version details.Which issue(s) this PR fixes:
Unblocks #670
Special notes for your reviewer:
N/A