Fix port allocation race condition during tests. #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by now keeping the port open while calling next port library. This prevents races were 2 processes think the same port is available during the old model which was check open, close, blind reopen.
This change replaces nextport with using :0 as the random port number as well as providing a class to get the port only once to prevent multiple threads from using it.
Also increasing the test runs to 25x from 10x to reduce the risk of introducing more flakes.
Resolves #205.
Resolves #213