Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set fontc --emit-ir=false #225

Merged
merged 3 commits into from Mar 30, 2023
Merged

allow to set fontc --emit-ir=false #225

merged 3 commits into from Mar 30, 2023

Conversation

anthrotype
Copy link
Member

Fixes #224

credits to @rsheeter for the hint to using ArgAction::Set

clap-rs/clap#1649 (comment) might offer a path

@anthrotype
Copy link
Member Author

anthrotype commented Mar 30, 2023

hm why am I getting:

the trait bound SmolStr: Serialize is not satisfied

https://github.com/googlefonts/fontmake-rs/actions/runs/4567180455/jobs/8060649666?pr=225#step:4:176

when I run my pre-push git hook before pushing, it did not catch this?!
Similarly if I cargo clean just to be safe, and then I run cargo test --all-targets --all-features like the CI also does, it PASSES on my local machine... 😕

@anthrotype
Copy link
Member Author

turns out, I had to run cargo update so that my local Cargo.lock would get updated (the CI runs from clean directory and has no Cargo.lock so fetches whatever is available), and then I was able to repro the error locally with smol_str = "1.1.25". Apparently the serde feature is now optional in the latest version so must be declared explicitly.

Copy link
Contributor

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to see if I can reproduce a GH bug. Also I'm fine if you merge this when ready :)

@anthrotype anthrotype merged commit f33741e into main Mar 30, 2023
6 checks passed
@anthrotype anthrotype deleted the clap-bool-flags branch March 30, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fontc] --emit-ir=false leads to TasksFailed([(Be(Font), "IO failure")])
2 participants