Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dep)!: upgrade gts 2.0.0 #146

Closed
wants to merge 1 commit into from
Closed

chore(dep)!: upgrade gts 2.0.0 #146

wants to merge 1 commit into from

Conversation

summer-ji-eng
Copy link
Contributor

googleapis/google-cloud-node#2972
No engine in this library

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2020
@summer-ji-eng
Copy link
Contributor Author

@bcoe Could you take a look this libary?

  1. No Engine specified in package.json. Should I add Node Engine here, or just leave as original?
  2. Linter fail because no *.js files to lint, in this library, src/ and test/ are all .ts file. Any suggestion here?

Thanks :) 😊 🙏

@summer-ji-eng summer-ji-eng requested a review from bcoe March 26, 2020 00:19
@bcoe bcoe changed the title chore(dep): upgrade gts 2.0.0 chore(dep)!: upgrade gts 2.0.0 Mar 26, 2020
@JustinBeckwith
Copy link
Contributor

Fixed in #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@summer-ji-eng @JustinBeckwith @googlebot